supported smaller package metadata API #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestander
changed the title
bestander
changed the title
|
For review: avoid the last commit |
|
Nice! |
cpojer
reviewed
Apr 12, 2017
src/registries/npm-registry.js
Outdated
| const headers = {}; | ||
| const headers = { | ||
| 'Accept': 'application/vnd.npm.install-v1+json' | ||
| }; |
There was a problem hiding this comment.
Does that count as one line? :P
arcanis
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to https://github.com/npm/registry/blob/master/docs/responses/package-metadata.md we can now use smaller metadata API that does not have all the unnecessary descriptions etc.
Test plan
React Native:
material2:
Results:
This PR reduces metadata downloads by 40%.
Full metadata to packages is about 10-20% of total download.
There should be some minor improvements for Yarn memory now that it does not need to pass around the extra meta data.