Use an alias system instead of camelCase function #3101
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* @flow */ | ||
|
|
||
| import unsupportedAliases from '../../src/cli/unsupported-aliases.js'; | ||
|
|
||
| test('shorthands and affordances', () => { | ||
| expect(unsupportedAliases['run-script']).toBe('run'); | ||
| expect(unsupportedAliases['c']).toBe('config'); | ||
| expect(unsupportedAliases['i']).toBe('install'); | ||
| expect(unsupportedAliases['ls']).toBe('list'); | ||
| expect(unsupportedAliases['rb']).toBe('rebuild'); | ||
| expect(unsupportedAliases['runScript']).toBe('run'); | ||
| expect(unsupportedAliases['t']).toBe('test'); | ||
| expect(unsupportedAliases['tst']).toBe('test'); | ||
| expect(unsupportedAliases['un']).toBe('remove'); | ||
| expect(unsupportedAliases['up']).toBe('upgrade'); | ||
| expect(unsupportedAliases['v']).toBe('version'); | ||
| expect(unsupportedAliases['add-user']).toBe('login'); | ||
| expect(unsupportedAliases['dist-tag']).toBe('tag'); | ||
| expect(unsupportedAliases['dist-tags']).toBe('tag'); | ||
| expect(unsupportedAliases['adduser']).toBe('login'); | ||
| expect(unsupportedAliases['author']).toBe('owner'); | ||
| expect(unsupportedAliases['isntall']).toBe('install'); | ||
| expect(unsupportedAliases['la']).toBe('list'); | ||
| expect(unsupportedAliases['ll']).toBe('list'); | ||
| expect(unsupportedAliases['r']).toBe('remove'); | ||
| expect(unsupportedAliases['rm']).toBe('remove'); | ||
| expect(unsupportedAliases['show']).toBe('info'); | ||
| expect(unsupportedAliases['uninstall']).toBe('remove'); | ||
| expect(unsupportedAliases['update']).toBe('upgrade'); | ||
| expect(unsupportedAliases['verison']).toBe('version'); | ||
| expect(unsupportedAliases['view']).toBe('info'); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "test_generate_lock_entry", | ||
| "version": "1.0.0", | ||
| "license": "UNLICENSED" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,6 @@ | ||
| /* @flow */ | ||
|
|
||
| export default({ | ||
| 'upgrade-interactive': 'upgradeInteractive', | ||
| 'generate-lock-entry': 'generateLockEntry', | ||
| }: { [key: string]: string }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,88 @@ | ||
| /* @flow */ | ||
| import {ConsoleReporter, JSONReporter} from '../../reporters/index.js'; | ||
| import * as constants from '../../constants.js'; | ||
| import {MessageError} from '../../errors.js'; | ||
| import Config from '../../config.js'; | ||
|
|
||
| const chalk = require('chalk'); | ||
|
|
||
| const getDocsLink = (name) => `${constants.YARN_DOCS}${name || ''}`; | ||
| const getDocsInfo = (name) => 'Visit ' + chalk.bold(getDocsLink(name)) + ' for documentation about this command.'; | ||
|
|
||
| const commands = {}; | ||
|
|
||
| import * as access from './access.js'; commands['access'] = access; | ||
| import * as add from './add.js'; commands['add'] = add; | ||
| import * as bin from './bin.js'; commands['bin'] = bin; | ||
| import * as cache from './cache.js'; commands['cache'] = cache; | ||
| import * as check from './check.js'; commands['check'] = check; | ||
| import * as clean from './clean.js'; commands['clean'] = clean; | ||
| import * as config from './config.js'; commands['config'] = config; | ||
| import * as generateLockEntry from './generate-lock-entry.js'; commands['generateLockEntry'] = generateLockEntry; | ||
| import * as global from './global.js'; commands['global'] = global; | ||
| import * as help from './help.js'; commands['help'] = help; | ||
| import * as import_ from './import.js'; commands['import'] = import_; | ||
| import * as info from './info.js'; commands['info'] = info; | ||
| import * as init from './init.js'; commands['init'] = init; | ||
| import * as install from './install.js'; commands['install'] = install; | ||
| import * as licenses from './licenses.js'; commands['licenses'] = licenses; | ||
| import * as link from './link.js'; commands['link'] = link; | ||
| import * as login from './login.js'; commands['login'] = login; | ||
| import * as logout from './logout.js'; commands['logout'] = logout; | ||
| import * as list from './list.js'; commands['list'] = list; | ||
| import * as outdated from './outdated.js'; commands['outdated'] = outdated; | ||
| import * as owner from './owner.js'; commands['owner'] = owner; | ||
| import * as pack from './pack.js'; commands['pack'] = pack; | ||
| import * as publish from './publish.js'; commands['publish'] = publish; | ||
| import * as remove from './remove.js'; commands['remove'] = remove; | ||
| import * as run from './run.js'; commands['run'] = run; | ||
| import * as tag from './tag.js'; commands['tag'] = tag; | ||
| import * as team from './team.js'; commands['team'] = team; | ||
| import * as unlink from './unlink.js'; commands['unlink'] = unlink; | ||
| import * as upgrade from './upgrade.js'; commands['upgrade'] = upgrade; | ||
| import * as version from './version.js'; commands['version'] = version; | ||
| import * as versions from './versions.js'; commands['versions'] = versions; | ||
| import * as why from './why.js'; commands['why'] = why; | ||
| import * as upgradeInteractive from './upgrade-interactive.js'; commands['upgradeInteractive'] = upgradeInteractive; | ||
|
There was a problem hiding this comment. It might be clearer to do something like this: import * as bar from './bar';
import * as foo from './foo';
...
let commands = {
bar,
foo,
...
};What do you think? There was a problem hiding this comment. I think is A LOT clearer; i will change it! |
||
|
|
||
| import buildUseless from './_useless.js'; | ||
|
|
||
| commands['lockfile'] = buildUseless( | ||
| "The lockfile command isn't necessary. `yarn install` will produce a lockfile.", | ||
| ); | ||
|
|
||
| commands['dedupe'] = buildUseless( | ||
| "The dedupe command isn't necessary. `yarn install` will already dedupe.", | ||
| ); | ||
|
|
||
| commands['prune'] = buildUseless( | ||
| "The prune command isn't necessary. `yarn install` will prune extraneous packages.", | ||
| ); | ||
|
|
||
| for (const key in commands) { | ||
| commands[key].getDocsInfo = getDocsInfo(key); | ||
| } | ||
|
|
||
| import aliases from '../aliases.js'; | ||
|
|
||
| for (const key in aliases) { | ||
| commands[key] = commands[aliases[key]]; | ||
| commands[key].getDocsInfo = getDocsInfo(key); | ||
| } | ||
|
|
||
| import unsupportedAliases from '../unsupported-aliases.js'; | ||
|
|
||
| for (const key in unsupportedAliases) { | ||
| commands[key] = { | ||
| run(config: Config, reporter: ConsoleReporter | JSONReporter): Promise<void> { | ||
| throw new MessageError(`Did you mean \`yarn ${unsupportedAliases[key]}\`?`); | ||
| }, | ||
| setFlags: () => {}, | ||
| hasWrapper: () => true, | ||
| getDocsInfo: getDocsInfo(unsupportedAliases[key]), | ||
| }; | ||
| } | ||
|
|
||
| export default ({ | ||
| ...commands, | ||
| }: { [key: string]: Object }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsopported? :p(same typo on 214 and 221 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaaah thanks and sorry XD