Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --ignore-scripts flag to integrity check #3094

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

bestander
Copy link
Member

Summary

--ignore-scripts affects the underlying node_modules and should be factored in integrity check

Test plan

  • added test
  • manual
bestander-mbp:left-pad bestander$ yarn install --ignore-scripts
yarn install v0.24.0-0
warning No license field
[1/4] 🔍  Resolving packages...
warning Integrity check: Flags don't match
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
warning Ignored scripts due to flag.
✨  Done in 0.55s.

bestander-mbp:left-pad bestander$ yarn check --integrity
yarn check v0.24.0-0
warning No license field
warning Integrity check: Flags don't match
error Integrity check failed
error Found 1 errors.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

bestander-mbp:left-pad bestander$ yarn check --integrity --ignore-scripts
yarn check v0.24.0-0
warning No license field
success Folder in sync.
✨  Done in 0.06s.

--ignore-scripts affects the underlying node_modules and should be factored in integrity check
@bestander bestander requested a review from arcanis April 10, 2017 22:05
@bestander bestander merged commit e8092bd into yarnpkg:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants