Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks that the webpack builds are working properly #3064

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Apr 7, 2017

Summary

This PR adds a small script to make sure that the generated artifacts (the two most recently modified files) are working properly after build-webpack.js has been called.

@arcanis arcanis requested review from Daniel15 and bestander April 7, 2017 11:01
@bestander bestander merged commit 2f50ad6 into yarnpkg:master Apr 7, 2017
arcanis added a commit to arcanis/yarn that referenced this pull request Apr 7, 2017
bestander pushed a commit that referenced this pull request Apr 7, 2017
* Checks that the webpack builds are working properly (#3064)

* Fix missing subdeps in production install when those are present in devDependencies list (#2921)

* Test for install skipping subdependencies when those are named in root devDependencies

* Add 'incompatible' flag to references, use that to ignore incompatible packages instead of faulty inherit logic. Fixes #2819

* Unconditionally mark packages as ignored, hoister now fully corrects transitive uses

* replaced deprecated asserts (#3069)

* fixing lint (#3070)

* Fixes integrity check for --production flag (#3067)

* fixed integrity check when running with --production

* added test

* removed unused var

* Remove the dependency on the "rc" module (#3063)

* Removes dependency on the "rc" module

* Removers shebang-loader, not used anymore

* Fixes flow errors

* Fixes tests on Windows
@Daniel15
Copy link
Member

Daniel15 commented Apr 7, 2017

Thanks! I'd prefer if it was something more explicit, something like:

node ./artifacts/yarn-$version.js --version
node ./artifacts/yarn-legacy-$version.js --version

I'll roll that change into #3030 (I'll probably land #3030 this weekend)

Daniel15 added a commit to Daniel15/yarn that referenced this pull request Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants