Fix undefined error when package has no binaries #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we installed a package which apparently didn't have any binary. The console message however was: `warning undefined has no binaries`. This happens because [`packageHasNoBinaries`](https://github.com/yarnpkg/yarn/blob/6e9a9a6596ca8f177f68f6672a1ef4ff16705336/src/reporters/lang/en.js#L252) has 1 argument, which this call to the reporter does not serve. Therefore the package name will be undefined.
|
Good catch 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today we installed a package which apparently didn't have any binary.
The console message however was:
warning undefined has no binaries.This happens because
packageHasNoBinarieshas 1 argument, which this call to the reporter does not serve.Therefore the package name will be undefined.
Test plan
Given that the warning is not working properly (recursion, anyone? 😄 ), we suspect that the package was
generator-polymer-init-custom-build.Running
yarn global add generator-polymer-init-custom-buildshows the following output:With this fix, the output is: