Add tests for cache commands #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Mar 27, 2017
__tests__/commands/cache.js
Outdated
| const out = new stream.PassThrough(); | ||
| const reporter = new reporters.ConsoleReporter({stdout: out}); | ||
| await run(config, reporter, {}, ['ls']); | ||
| const stdout = String(out.read()); |
There was a problem hiding this comment.
Wouldn't it be easier and more reliable to use the JSON reporter and check its output?
voxsim
force-pushed
the
add-tests-for-cache-commands
branch
from
a2885c9 to
799a8d7
Compare
voxsim
force-pushed
the
add-tests-for-cache-commands
branch
from
799a8d7 to
1f80127
Compare
|
@arcanis now I am using a JSON reporter and for what I see the broken tests are not related to my pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Test plan
As described in the title this commit add tests for cache commands.