Upgrade camelcase + flow and specify supported engines #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were several packages reported as outdated by
yarn outdated. I upgradedcamelcaseto4.0.0which dropped support for Node 4. I also upgradedflow-binto0.40.0which brought some stricter type checking. Most notably the tuple changes introduced in 0.38.0 required some changes.Also I saw that the
package.jsondid not specify the supported Node engines. I added this and set to Node 4, since AppVeyor and Travis still build on Node 4.Test plan
I ran
yarn upgradeto update packages which were still in valid semver range. Then I ranyarnafter updating the two packages listed above. I ranyarn run build && yarn testto verify that the code is linted and still works.