Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests when path location of yarn contains spaces #2700

Merged
merged 1 commit into from
Feb 19, 2017

Conversation

Keraito
Copy link
Contributor

@Keraito Keraito commented Feb 15, 2017

Summary

If the path location for Yarn contains spaces, the test suite would fail on a command. The corresponding upstream issue on Node is nodejs/node#6803. This specific comment noted that the path should be escaped with double quotes.

Test plan

  1. The path location to Yarn needs to contain spaces.
  2. Run yarn run test.
  3. Observe a command fail with a corrupted path location.

@bestander bestander merged commit 9a9a8ba into yarnpkg:master Feb 19, 2017
@bestander
Copy link
Member

Much appreciated, thanks

@TimvdLippe TimvdLippe deleted the fix-space-path branch February 19, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants