Fixes race condition on yarn install mutex network #2092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition we observed in production, to easily reproduce it, I changed the code in
onServerEnd
to wait any amount of time before resolving:This change makes it easier to spot the issue
Test plan
run:
IIRC The original code was written like that because I observed some issue in relying on the
close
event on my original implementation that was using a unix socket.Since then I changed the strategy and we use the network.
I cannot recreate the problem observed with this implementation.
I believe using the correct events is also much cleaner :)