Check and cleanup node_modules before install #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #84 and also optimises scenarios when multiple `kpm install` instances are running
ghost
added
bestander
changed the title
bestander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84, #161
I thought of doing some partial cleanup in package-linker.js that would analyze what is already installed and what needs to be installed but it ended up a bit too complex for me.
Instead I just run
checkcommand before installation.This also optimizes scenario when 2 or more
installcommands are started at the same time because second and third installation will bail fast after the successful check.The down side is an extra
checkrunning every installation.