Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release of Windows installer. #1999

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

Daniel15
Copy link
Member

Summary

This automates signing the Windows installer and attaching it to the releases. Windows installers built via AppVeyor will now have an -unsigned suffix in their filenames, and the code that signs the installer will remove the suffix after signing it. This signing code is running on the same server that's handling hosting the nightly builds.

This might need a bit of hand-holding / monitoring for the very next release we do, to ensure that everything works as expected. cc @bestander

Once we ensure this is working, we can automate bumping the latest_release config field on the website, and the release process will be fully automated! 🎉

Test plan

Played around with it in my fork, manually called the webhook with a valid AppVeyor payload and ensured it worked (https://github.com/Daniel15/yarn/releases/tag/v0.18.0-0)

Closes #1977

@bestander bestander merged commit dfeabcc into yarnpkg:master Nov 24, 2016
Daniel15 added a commit that referenced this pull request Nov 28, 2016
@Daniel15
Copy link
Member Author

@bestander - I just realised I forgot to merge this into the 0.17-stable branch. Just merged it now, so this should take effect for the next 0.17.x release we do 😄

@Daniel15 Daniel15 deleted the authenticode branch November 28, 2016 19:40
@bestander
Copy link
Member

bestander commented Nov 28, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate release of Windows installer
2 participants