Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the artifact that caused the error when a malformed request is found #1996

Merged

Conversation

peterjanes
Copy link
Contributor

Summary

When an object downloaded from the registry doesn't have a "dist-tags" property, an error is displayed. However, it doesn't include the name of the object that caused the error, which makes it difficult to debug.

Test plan

No additional tests; just a text change.

@wyze
Copy link
Member

wyze commented Nov 23, 2016

Can you give an example on where I can make this happen?

@peterjanes
Copy link
Contributor Author

I have it occur regularly retrieving the "natives" package when using a proxy. (According to Sonatype, "natives" was unpublished and republished a few days later, so the cached metadata may be corrupt.)

@peterjanes
Copy link
Contributor Author

This builds on #1356, by the way, which fixed #1348.

@bestander bestander merged commit 3ef999c into yarnpkg:master Nov 24, 2016
@navels
Copy link

navels commented Nov 28, 2016

@peterjanes we are running into this same problem. do you have a ticket number with Sonatype or a workaround or any other information?

ah, seems that by invalidating the cache in nexus it is now fixed. still, am interested if there is a Sonatype ticket.

@peterjanes
Copy link
Contributor Author

@navels Yes, invalidating the cache is the fix. The Sonatype ticket is 16374.

@peterjanes peterjanes deleted the improve-malformed-request-logging branch November 29, 2016 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants