When saving build artifacts, rather than copying, save list of files to ignore #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
bestander
pushed a commit
that referenced
this pull request
Nov 18, 2016
…to ignore (#1935) * When saving build artifacts, rather than copying, save list of files to ignore * fix lint and tests * fix test fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the build artifact copying to our cache and instead saves a list of the build artifact files so we ignore them when considering files extraneous inside modules. We need to save this list to distinguish build artifacts (which we should keep) and other extraneous files.
If we consider build artifacts to be extraneous then it'd require running all install scripts, even if they weren't touched, on every single install which is excessively expensive.
Test plan
Tests were added.
$ jest.