Add test for global add with prefix

[torifat]

Summary

Test case for global add <package> --prefix <path>

Covers #1877

[onemen]

This PR doesn't fix the issue of add-without-flag test.
The test installs react-native to the user global bin folder

After yarn global add react-native-cli this is the content of the file react-native in my bin folder

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir//bin/sh" ]; then
  "$basedir//bin/sh"  "$basedir/config/global/node_modules/.bin/react-native" "$@"
  ret=$?
else 
  /bin/sh  "$basedir/config/global/node_modules/.bin/react-native" "$@"
  ret=$?
fi
exit $ret

After jest __tests__\commands\global.js the original file replaced with this one.
This breaks my react-native when the temp folder no longer exist.

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir//bin/sh" ]; then
  "$basedir//bin/sh"  "$basedir/../Temp/yarn-add-without-flag-0.8375984502260758/.yarn/.global/node_modules/.bin/react-native" "$@"
  ret=$?
else 
  /bin/sh  "$basedir/../Temp/yarn-add-without-flag-0.8375984502260758/.yarn/.global/node_modules/.bin/react-native" "$@"
  ret=$?
fi
exit $ret

As you can see in #1918, i solved this issue by adding

+  // set global bin
+  if (!flags.prefix) {
+    flags.prefix = path.join(cwd, '.yarn', '.global', '.bin');
+  }

to runGlobal function. to make sure that all global test will NOT Use the global bin folder

[torifat]

This PR doesn't fix the issue of add-without-flag test.

@onemen I'm confused. Why this PR need to fix it? And, I also didn't mention anywhere that it does. Also, your PR and this PR is mutually exclusive. Or I'm missing anything here?

After yarn global add react-native-cli this is the content of the file react-native in my bin folder

I have already told you in another place that the test I wrote is not an ideal one and doesn't cover everything. That was a basic guard so that we don't ship global completely broken, like we did in v0.17.0.

And, similarly this PR to address just a specific bug, just to prevent regression.

As you can see in #1918, i solved this issue by adding

I tried your PR locally and it fails.

[torifat]

After jest tests\commands\global.js the original file replaced with this one.
This breaks my react-native when the temp folder no longer exist.

This is a valid concern. So, please fix your PR so that we can merge it.

[onemen]

I tried your PR locally and it fails.

That's odd, in my local fork it pass

yarn>jest __tests__\commands\global.js > nul
 PASS  __tests__\commands\global.js (9.562s)
  √ add without flag (7186ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        10.034s
Ran all test suites matching "__tests__\commands\global.js".

I'm on windows 10 the files copy to
C:\Users\Onemen\AppData\Local\Temp\yarn-add-without-flag-0.39320614322312464\.yarn\.global\.bin

[onemen]

See the modification I have made in #1918 to fix the path on different platform
Change this line accordingly:
- assert.ok(await fs.exists(path.join(tmpGlobalFolder, 'bin', 'react-native')));
+ assert.ok(await fs.exists(path.join(getBinFolder(tmpGlobalFolder), 'react-native')));

[torifat]

Thanks

[bestander]

Hi, @torifat.
Sorry I was busy tracking down some 0.17 issues.
This one is on my list.
Do you still want it to be merged?

[torifat]

@bestander No. Because of #2007 I have closed this one and created a new PR at #2025.

[bestander]

Cool, I'll get to it as soon as I clear some debts

[torifat]

It failed 😄 I have to make it pass first.