Add webhook for archiving CircleCI build artifacts #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK this should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Archives builds from CircleCI into our directory for nightly builds. I'm using the phrase "nightly" but I really mean "unstable" as it's archived after every build, not once per night.
Test plan
¯_(ツ)_/¯
This probably needs more testing - The script it's calling intentionally ignores all requests that aren't for the master branch of yarnpkg/yarn repo as we don't want to archive random stuff from other repos or branches, but that means that I can't actually test it in my fork at the moment 😛 I might just create a copy of the archiving script and play with it some more in my fork.