Bugfixes to yarn pack, partly fixes #755 #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the tests for node 4 but travis is still failing, I have no idea why. |
npm pack includes some files even if they are not included in the “files” field in package.json. This commit creates the same behaviour in yarn pack.
if files is used in package.json all other files should be excluded. Files with dot as first character have to be excluded explicitly because minimatch will not match them by default.
|
Ok I have updated to skip the failing test for now, but the error message ist still there. |
bestander
added a commit
that referenced
this pull request
Nov 27, 2016
|
@T-Obi, I had to revert the merge because of CI issue https://circleci.com/gh/yarnpkg/yarn/2330. |
bestander
pushed a commit
that referenced
this pull request
Nov 29, 2016
* add tests for pack with files-array * include mandatory files if not in files-array npm pack includes some files even if they are not included in the “files” field in package.json. This commit creates the same behaviour in yarn pack. * explicitly exclude dotfiles in pack with files if files is used in package.json all other files should be excluded. Files with dot as first character have to be excluded explicitly because minimatch will not match them by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains two fixes for yarn pack if "files" is used in package.json:
Please note that this only partly fixes #755 .
As far as I can see what happens in #755 is the following:
While working on this I was wondering why a missing file would create a corrupt archive, but it seemed to be fixed at first. Then I added some more testcases and noticed that it is still possible to create corrupt archives, but this is not limited to the usage of "files" - see #1442.
Basically I think some directory was falsely included, and that invoked the bug described in #1442 .
But a missing or included file does not directly result in a corrupt archive.
Hope this makes sense, I find it difficult to explain right now.
Test plan
I have added some tests for this, just run yarn test.
If you want to see the failing tests checkout 6612ec6.