Minor README tweaks #1452
Merged
Minor README tweaks #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatting, phrasing, etc.
|
@thejameskyle mind taking a look? |
jamiebuilds
reviewed
Oct 26, 2016
| @@ -19,23 +19,23 @@ | |||
|
|
|||
| **Fast:** Yarn caches every package it downloads so it never needs to download the same package again. It also parallelizes operations to maximize resource utilization so install times are faster than ever. | |||
|
|
|||
| **Reliable:** Using a detailed, but concise, lockfile format, and a deterministic algorithm for installs, Yarn is able to guarantee that an install that worked on one system will work exactly the same way on any other system. | |||
| **Reliable:** Thanks to a detailed (but concise) lockfile format and a deterministic algorithm for installs, Yarn is able to guarantee that an install that worked on one system will work exactly the same way on any other system. | |||
There was a problem hiding this comment.
Using a detailed, but concise, lockfile format
This was better as is
There was a problem hiding this comment.
What about
-Using a detailed, but concise, lockfile format, and a deterministic algorithm for installs,
+Using a detailed, concise lockfile format and a deterministic algorithm for installs,I don't think we need the "but".
jamiebuilds
reviewed
Oct 26, 2016
| * **Offline Mode.** If you've installed a package before, you can install it again without any internet connection. | ||
| * **Deterministic.** The same dependencies will be installed in the same exact way on any machine, regardless of install order. | ||
| * **Network Performance.** Yarn efficiently queues up requests and avoids request waterfalls in order to maximize network utilization. | ||
| * **Multiple Registries.** Install any package from either npm or Bower. Keep your package workflow the same. |
There was a problem hiding this comment.
we should remove this bullet point
There was a problem hiding this comment.
The change here seems reasonable, but if @thejameskyle thinks it should be removed, then let's remove it.
There was a problem hiding this comment.
Bower support is being removed
|
cc @JoelMarcey - Any other thoughts on these phrasing changes? |
|
@Daniel15 The changes seem good and reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatting, phrasing, etc.