add symlink link: dependency type (fixes #884) #1109
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
link:
dependency type, see #884 for reasons.I tried to integrate it as smoothly as possible in the existing code base, I chose to implement a noop
LinkFetcher
class instead of forking away the default resolving/fetching process.Will gladly refactor if needed.
Test plan
With the following
package.json
:Had to improve the
possibleExtraneous
logic to handle scoped packages as well (scope folder would be removed onyarn add
).