-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit returns Unexpected audit response (Missing Metadata): false
#6607
Comments
Ping @rally25rs - I know that the npm registry often yields 500, maybe it's what happens there and we don't properly catch it? |
If you run with Also, please provide your dependencies. |
When I run yarn --audit, it says 1 vulnerbility is detected and asked me to run yarn audit.
|
@bugzpodder As @rally25rs mentioned, the package.json and yarn.lock would be helpful 🙂 |
Here's the output from
Sorry, I can't post my package.json. But it is something about the deps since |
|
Able to reproduce with the following package.json: {
"dependencies": {
"textract": "2.1.2"
}
} yarn.lock:
|
I like how the npm registry returns It seems like there are two issues. The first one is fixed by #6611 (you can see it because it then works if you replace |
It can be reproduced with |
All dependencies of |
Found it - {
"dependencies": {
"exit-on-epipe":"",
"xlsx": "",
"concat-stream":"",
"commander":""
}
} |
Yeah it looks like a chunk of the json yarn is posting is:
@arcanis what I was doing in these situations was to run |
I also get this issue if my root package.json (workspace root) does not contain a |
Quick update.
So when we post data to the npm audit API, we send
This causes an error (Bad Request) from the API. Looking at what npm sends, they send:
npm's Not sure yet where they are getting versions for |
@rally25rs shouldn't #6611 workaround the issue (we fallback to |
This finally includes the patch for [Yarn issue 6607](yarnpkg/yarn#6607) which was breaking lots of scans. Will also use a minor version bump for this since it includes the new Yarn version and an updated version of Ruby.
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.
Run
yarn audit
.What is the expected behavior?
No error. Or provide docs on how to resolve if it is a setup issue (yarnpkg/website#877).
Please mention your node.js, yarn and operating system version.
Node: v8.12.0
Yarn: v1.12.1 (installed via Homebrew)
OS: macOS
The text was updated successfully, but these errors were encountered: