Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install local tgz file after upgraded to node 10 #5761

Closed
a9udn9u opened this issue Apr 30, 2018 · 2 comments · Fixed by #5769
Closed

Unable to install local tgz file after upgraded to node 10 #5761

a9udn9u opened this issue Apr 30, 2018 · 2 comments · Fixed by #5769
Assignees

Comments

@a9udn9u
Copy link

a9udn9u commented Apr 30, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
Install local tgz file either hang at 'Resolving packages' or exit after 'Fetching packages'

If the current behavior is a bug, please provide the steps to reproduce.

I've created this test package. Just run yarn add file:../b.tgz in package a. b.tgz is packed by yarn pack.

What is the expected behavior?
tgz file gets unpacked and installed.

Please mention your node.js, yarn and operating system version.
yarn: 1.6.0
nodejs: 10.0.0
OS: macOS 10.12.6

More details.
The problem started right after I upgrade to node 10, before it worked fine.

Sometimes yarn hang at 'Resolving packages'

yarn add v1.6.0
(node:1191) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
verbose 0.544 Checking for configuration file "/private/tmp/yarn/a/.npmrc".
verbose 0.544 Checking for configuration file "/Users/quangan/.npmrc".
verbose 0.545 Found configuration file "/Users/quangan/.npmrc".
verbose 0.545 Checking for configuration file "/usr/local/etc/npmrc".
verbose 0.546 Checking for configuration file "/private/tmp/yarn/a/.npmrc".
verbose 0.546 Checking for configuration file "/private/tmp/yarn/.npmrc".
verbose 0.546 Checking for configuration file "/private/tmp/.npmrc".
verbose 0.546 Checking for configuration file "/private/.npmrc".
verbose 0.549 Checking for configuration file "/private/tmp/yarn/a/.yarnrc".
verbose 0.549 Checking for configuration file "/Users/quangan/.yarnrc".
verbose 0.549 Found configuration file "/Users/quangan/.yarnrc".
verbose 0.549 Checking for configuration file "/usr/local/etc/yarnrc".
verbose 0.55 Checking for configuration file "/private/tmp/yarn/a/.yarnrc".
verbose 0.55 Checking for configuration file "/private/tmp/yarn/.yarnrc".
verbose 0.55 Checking for configuration file "/private/tmp/.yarnrc".
verbose 0.55 Checking for configuration file "/private/.yarnrc".
verbose 0.552 current time: 2018-04-30T16:59:20.229Z
info No lockfile found.
[1/4] 🔍  Resolving packages...
⢀ file:../b.tgz

Sometimes it dies after 'Fetching packages'

yarn add v1.6.0
(node:5003) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
verbose 0.261 Checking for configuration file "/tmp/app/.npmrc".
verbose 0.261 Checking for configuration file "/Users/quangan/.npmrc".
verbose 0.261 Checking for configuration file "/usr/local/etc/npmrc".
verbose 0.261 Checking for configuration file "/tmp/app/.npmrc".
verbose 0.262 Checking for configuration file "/tmp/.npmrc".
verbose 0.263 Checking for configuration file "/tmp/app/.yarnrc".
verbose 0.263 Checking for configuration file "/Users/quangan/.yarnrc".
verbose 0.263 Found configuration file "/Users/quangan/.yarnrc".
verbose 0.263 Checking for configuration file "/usr/local/etc/yarnrc".
verbose 0.263 Checking for configuration file "/tmp/app/.yarnrc".
verbose 0.263 Checking for configuration file "/tmp/.yarnrc".
verbose 0.264 Found configuration file "/Users/quangan/.yarnrc".
verbose 0.264 Checking for configuration file "/Users/.yarnrc".
verbose 0.265 current time: 2018-04-27T05:11:53.672Z
[1/4] 🔍  Resolving packages...
verbose 0.401 Performing "GET" request to "https://registry.yarnpkg.com/uuid".
verbose 0.545 Request "https://registry.yarnpkg.com/uuid" finished with status code 200.
[2/4] 🚚  Fetching packages...
[#################################################################################################################################################################################################################################] 834/835

There is no yarn-error.log file.

@imsnif
Copy link
Member

imsnif commented May 2, 2018

Hey @a9udn9u - thanks for bringing this up. This issue is addressed by #5769

Hoping to have it merged soon.

@theandrewlane
Copy link
Contributor

@imsnif - I have verified your fix resolves this issue on MacOS High Sierra 10.13.3 w/Node 10.1.0 👍

@BYK BYK closed this as completed in #5769 May 23, 2018
BYK pushed a commit that referenced this issue May 23, 2018
**Summary**

1. Added node 10 to CircleCI
2. Fixed a test that was using the `net.createServer` method. This was having issues, likely because of this: nodejs/node#20334 - it now uses a "normal" `http` server instead, serving the same purpose.
3. Changed the `readFirstAvailableStream` method in `util/fs.js`. I'm guessing this is related to the same issue as 2, but there have been quite some changes in `10` that might be causing this - so it's just a guess. Since this piece of code could be clearer and more conceise anyway, I opted to just change it. Now instead of relying on the stream `error` event to check if a file exists, it just explicitly checks it before starting the stream.
4. Upgraded `upath` from `1.0.2` to `1.0.5` which supports node 10 (found through its `engines` field when installing).
5. Upgraded Jest
6. Fixed a bug regarding replacing symlinks to non-existent targets on Windows
7. Removed a redundant test
8. Fixed two test cases that were failing frequently on macOS builds

fixes #5761
fixes #5477

**Test plan**

CI should be green (including and especially the new node10 job!)
craig bot pushed a commit to cockroachdb/cockroach that referenced this issue Jul 10, 2018
27262: ui: require yarn >= 1.7.0 r=benesch,vilterp a=tschottdorf

Builds before the upgrade failed mysteriously.
@benesch (cc) suspects a bug in older versions of yarn.

```
$ make build
Running make with -j8
GOPATH set to /Users/tschottdorf/go
build/node-run.sh -C pkg/ui yarn install --offline
(echo "// Code generated by goyacc. DO NOT EDIT."; \
     echo "// GENERATED FILE DO NOT EDIT"; \
     cat pkg/sql/parser/gen/sql.go.tmp | \
     sed -E 's/^const ([A-Z][_A-Z0-9]*) =.*$/const \1 = lex.\1/g') > pkg/sql/parser/sql.go.tmp || rm pkg/sql/parser/sql.go.tmp
(echo "// Code generated by make. DO NOT EDIT."; \
     echo "// GENERATED FILE DO NOT EDIT"; \
     echo; \
     echo "package lex"; \
     echo; \
     grep '^const [A-Z][_A-Z0-9]* ' pkg/sql/parser/gen/sql.go.tmp) > pkg/sql/lex/tokens.go.tmp || rm pkg/sql/lex/tokens.go.tmp
mv -f pkg/sql/lex/tokens.go.tmp pkg/sql/lex/tokens.go
mv -f pkg/sql/parser/sql.go.tmp pkg/sql/parser/sql.go
yarn install v1.6.0
(node:50064) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[1/5] Validating package.json...
go install -v docgen
bin/prereqs ./pkg/cmd/docgen > bin/docgen.d.tmp
[2/5] Resolving packages...
mv -f bin/docgen.d.tmp bin/docgen.d
[3/5] Fetching packages...
build/node-run.sh pkg/ui/bin/gen-protobuf-cli-deps.js > pkg/ui/node_modules/protobufjs/cli/package.json
bash: pkg/ui/node_modules/protobufjs/cli/package.json: No such file or directory
make: *** [pkg/ui/yarn.installed] Error 1
make: *** Waiting for unfinished jobs....
```

Release note (general change): the build now requires yarn at version
1.7.0 or above, to work around yarnpkg/yarn#5761.

27307: storage: return TransactionRetryError from QueryIntent on pushed intent r=nvanbenschoten a=nvanbenschoten

Extracted from #26599.

This change adjusts how QueryIntent handles pushed intents. First, it
changes how pushed intents interact with SNAPSHOT transactions. Next,
it makes sure to update the response transaction in the case of pushed
intents. Finally, it returns a RETRY_SERIALIZABLE TransactionRetryError
for SERIALIZABLE transactions who observe a pushed intent with the
RETURN_ERROR behavior.

Release note: None

27329: log: use fake stacktrace when test-exiting r=benesch a=tschottdorf

Having stack traces littered across tests has been a long-standing pet
peeve of mine (and presumably others). We search through logs more often
than we would like to admit, and having to skip a number of intentional
stack traces is annoying.

Make it so that whenever the logging exit func is mocked, the stack
trace indicates that.

Release note: None

27348: engine: fix RocksDBBatchReader example comment r=nvanbenschoten a=nvanbenschoten

Release note: None

Co-authored-by: Tobias Schottdorf <[email protected]>
Co-authored-by: Nathan VanBenschoten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants