Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: check-install command #576

Closed
bestander opened this issue Oct 10, 2016 · 2 comments
Closed

RFC: check-install command #576

bestander opened this issue Oct 10, 2016 · 2 comments
Labels
cat-feature

Comments

@bestander
Copy link
Member

Do you want to request a feature or report a bug?

feature

What is the expected behavior?

Check and install are used in CI one after another quite often and there are benefits of having full check capability (e.g. --integrity option) in install command:

  • reduced startup time
  • ability to use --force-single-instance for both reducing issues with concurrent install scenarios

Please mention your node.js, yarn and operating system version.
node 6
yarn 0.14
@cpojer
Copy link
Contributor

cpojer commented Oct 11, 2016

Doesn't yarn install do that already?

facebook-github-bot pushed a commit to facebookarchive/fbshipit that referenced this issue Oct 12, 2016
@bestander
Integrated generic install-node-modules for React Native
fcad36b 
Summary:
Wacky nodeModules.js is replaced with install-node-modules.js.
A few concerns to address:
- I did not make it a `hg mv nodeModules.js ..../install-node-modules.js` because I want to start with clean-ish slate and have a good peer review to the script
- I did not want to use external dependencies for install-node-modules.js because I want this script to startup as fast as possible and don't want to either check in its dependencies or use yarn to install them. Otherwise I would use shell.js, node-fetch and optimist, still an option if this script proves to be a hassle to support

Things to come:
- hook up jsbuddy and flow on install-node-modules.js
- yarnpkg/yarn#576
- yarnpkg/yarn#569
- yarnpkg/yarn#570

Usage for fbsource projects:
```
fbcode/react_native/kpm/wrapper/install-node-modules.sh fbsource/.../js-project
```

Reviewed By: yungsters

Differential Revision: D3996416

fbshipit-source-id: 078b2ca5c076c2c6e2e7209945e59aaa31ebc4aa
@bestander
Copy link
Member Author

install does an integrity check, that should be good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpojer @sebmck @bestander