Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline Mirror Automatic Pruning Is Deleting Prebuilt Packages #5614

Closed
theandrewlane opened this issue Apr 4, 2018 · 0 comments
Closed

Offline Mirror Automatic Pruning Is Deleting Prebuilt Packages #5614

theandrewlane opened this issue Apr 4, 2018 · 0 comments
Assignees
@arcanis
Labels
triaged

Comments

@theandrewlane
Copy link
Contributor

BUG Summary
When experimental-pack-script-packages-in-mirror is set with yarn-offline-mirror-pruning true, prebuilt packages in /yarn-offline-mirror-dir/prebuilt/* are deleted - as per PR #5314, these should not be deleted.

Expected Behavior:
Prebuilt packages are persisted when autopruning is active.

Environment

  • Node: 9.8.0
  • Yarn: latest from Master as of 4cbecf1 (1.6.0-0)
  • 💻: MacOS Sierra - 10.12.6
@ghost ghost assigned arcanis Apr 4, 2018
@ghost ghost added the triaged label Apr 4, 2018
@theandrewlane theandrewlane mentioned this issue Apr 4, 2018
Merged
theandrewlane added a commit to theandrewlane/yarn that referenced this issue Apr 4, 2018
@theandrewlane
Bugfix yarnpkg#5614: When offline pruning, don't unlink prebuilt pack…
e1722c7 
…ages.
@theandrewlane theandrewlane mentioned this issue Apr 4, 2018
Merged
bestander pushed a commit that referenced this issue Apr 4, 2018
@theandrewlane @bestander
Bugfix #5614: When offline pruning, don't unlink prebuilt packages. (#…
c844896 
…5616)
This was referenced Apr 11, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arcanis arcanis

Labels
triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arcanis @theandrewlane