-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add end-to-end tests for private packages #4186
Comments
I can take this one if it's ok |
@onurtemizkan go ahead and take it! The main issue here is who will own the test-related private packages? Looks like we can create a private repo under yarnpkg org and probably do the same with scoped packages on NPM but I'd rather hear what @bestander and @Daniel15 has to say about this first. Also may be @cpojer. |
Yes, I think full e2e with private npm repo is the way to go.
Whether it lives in yarnpkg it does not matter as long as we are fine with
security.
…On Wed, Aug 16, 2017 at 6:47 AM Burak Yiğit Kaya ***@***.***> wrote:
@onurtemizkan <https://github.com/onurtemizkan> go ahead and take it! The
main issue here is who will own the test-related private packages? Looks
like we can create a private repo under yarnpkg org and probably do the
same with scoped packages on NPM but I'd rather hear what @bestander
<https://github.com/bestander> and @Daniel15 <https://github.com/daniel15>
has to say about this first. Also may be @cpojer
<https://github.com/cpojer> .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4186 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWIW2uVlGNmi0YcutTecF9NCmHoZgks5sYvLkgaJpZM4O46pg>
.
|
I thought we already had an issue for this? |
@Daniel15 - I couldn't find it. Feel free to close this or the other as a duplicate if you bump into it. |
There was one but I did not create it, so can't find it. |
Relevant breaking issue right now with private registry libs completely failing to install |
We don't have e2e coverage for private packages which sometimes results in bugs going unnoticed until we make a release. We should have at least one smoke test for a very simple private package on NPM and private repo on GitHub or Bitbucket.
The text was updated successfully, but these errors were encountered: