-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn --flat sees a version conflict where there is none #3780
Comments
Related to #3778 and yarnpkg/rfcs#68 |
Yarn can see a conflict even when both dependencies resolve to the same version number:
Of course the code is actually different depending on whether it is fetched from NPM or from Gitlab. In our case, NPM will happily use the Gitlab version to satisfy both dependencies. Should Yarn do the same? Admittedly, this is a hacky way to get NPM to use our patched version of |
Ugh, that's actually worse than I realized. Even though it's prompting, the answer is effectively ignored in my above example, since the call to |
…el dependency (#4488) **Summary** Fixes #3780, and makes the failing test from #3779 passing. As a final step of package resolution, for each dependency we check whether any version satisfies all resolved version ranges. **Test plan** Fixes an existing (failing) test: "unbound transitive dependencies should not conflict with top level dependency"
…el dependency (yarnpkg#4488) **Summary** Fixes yarnpkg#3780, and makes the failing test from yarnpkg#3779 passing. As a final step of package resolution, for each dependency we check whether any version satisfies all resolved version ranges. **Test plan** Fixes an existing (failing) test: "unbound transitive dependencies should not conflict with top level dependency"
Do you want to request a feature or report a bug?
bug
What is the current behavior?
yarn --flat
sees a version conflict where there is none (in >=0.27.0).If I have package A that requires 'left-pad@>=1.0.1" and package B that requires both A and "[email protected]", and install package B with
yarn --flat
there is a conflict.If the current behavior is a bug, please provide the steps to reproduce.
https://github.com/mxmul/yarn_flat_regression
What is the expected behavior?
yarn would choose the one version that satisfies the version constraints (1.1.1)
Please mention your node.js, yarn and operating system version.
[email protected]
[email protected]
[email protected]
The text was updated successfully, but these errors were encountered: