Skip to content

Commit

Permalink
fix(install): connectionOptions passes in localhost as its host to pr…
Browse files Browse the repository at this point in the history
…event popup on MacOsx. (#5006)

Summary
This is to fix #4983 to prevent the firewall popup on Mac OSX.

Test plan
Ran the following tasks

yarn run test
yarn run lint
Also validated that the popup no longer occurs by setting the alias
alias yarn="node /path/to/my/yarn/lib/cli/index.js"
and running yarn install --mutex network
  • Loading branch information
greyepoxy authored and kaylieEB committed Dec 4, 2017
1 parent ddf2f9a commit b827eae
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/cli/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ export function main({
return new Promise((resolve, reject) => {
const connectionOptions = {
port: +mutexPort || constants.SINGLE_INSTANCE_PORT,
host: 'localhost',
};

function startServer() {
Expand Down

0 comments on commit b827eae

Please sign in to comment.