display documentation link correctly in every case

yarnpkg · Apr 7, 2017 · b231c80 · b231c80
1 parent 5ce0d22
commit b231c80
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/__tests__/index.js b/__tests__/index.js
@@ -207,7 +207,7 @@ test.concurrent('should interpolate aliases', async () => {
   );
 });
 
-test.concurrent('should display correct documentation for aliases', async () => {
+test.concurrent('should display correct documentation link for aliases', async () => {
   await expectAnInfoMessageAfterError(
     execCommand('i', [], 'run-add', true),
     'Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.',
@@ -254,3 +254,17 @@ test.concurrent('should throws missing command for unknown command', async () =>
     'Command \"unknown\" not found',
   );
 });
+
+test.concurrent('should not display documentation link for unknown command', async () => {
+  await expectAnInfoMessageAfterError(
+    execCommand('unknown', [], 'run-add', true),
+    '',
+  );
+});
+
+test.concurrent('should display documentation link for known command', async () => {
+  await expectAnInfoMessageAfterError(
+    execCommand('add', [], 'run-add', true),
+    'Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.',
+  );
+});
diff --git a/src/cli/index.js b/src/cli/index.js
@@ -384,11 +384,12 @@ config.init({
     onUnexpectedError(err);
   }
 
-  if (commandName) {
-    const actualCommandForHelp = aliases[commandName] ? aliases[commandName] : commandName;
-    if (command && actualCommandForHelp) {
-      reporter.info(getDocsInfo(actualCommandForHelp));
-    }
+  if (aliases[commandName]) {
+    reporter.info(getDocsInfo(aliases[commandName]));
+  }
+
+  if (commands[commandName]) {
+    reporter.info(getDocsInfo(commandName));
   }
 
   process.exit(1);