Add E2E for Angular #481
Merged
Add E2E for Angular #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embraser01
force-pushed
the
e2e-angular
branch
3 times, most recently
from
acc4591 to
9e9b03b
Compare
Embraser01
commented
Sep 23, 2019
| @@ -27,6 +27,9 @@ export default class YarnCommand extends BaseCommand { | |||
| @Command.String(`--cache-folder`) | |||
| cacheFolder?: string; | |||
|
|
|||
| @Command.Boolean(`--silent`) | |||
| silent?: boolean = false; | |||
There was a problem hiding this comment.
Angular cli use the --silent option on yarn install... I added this only to bypass the problem, what should we do?
Embraser01
force-pushed
the
e2e-angular
branch
from
be198a9 to
cd52d5b
Compare
Embraser01
force-pushed
the
e2e-angular
branch
3 times, most recently
from
d43cf8a to
744ab72
Compare
Embraser01
force-pushed
the
e2e-angular
branch
from
79263b7 to
efdd075
Compare
|
I'll go ahead and merge this PR 😃 It would be really nice if we could figure out how to make things work without PnPify though ... maybe the first step would be to identify where is the TypeScript host instantiated? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Added an E2E test for Angular (#266).
Angular CLI is not fully supported for now, here is the list of all the commands working or not:
Package '...' is not a dependencyHow did you fix it?