Adds a node-gyp plugin #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
node-gyppackage is a bit magic in both Yarn and npm in that it is downloaded on-demand if the package requests it. It's a horrible thing to do because you have no way to guarantee which version ofnode-gypwill be used. Still, that's how the ecosystem currently works and there's some friction to change it so I'll have to live with it for now (lovell/sharp#924).This PR implements a plugin that causes
node-gypto be installed when called, unless overridden by an explicit dependency. There's one improvement over Yarn 1 and npm, though: you can enforce the version ofnode-gypthat gets used by using the newnode-gyp-magic-locatorsettings: