-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): use binjumper to work-around 'Terminate batch job' prompts on Windows #1808
Conversation
22d7aa8
to
33fe322
Compare
33fe322
to
82cb285
Compare
Would creating a Powershell script instead of CMD work? The builtin binaries approach is a bit magical, I'm slightly worry it would open us to weird differences between spawning a binary from a script versus from a shellscript spawned by a script 🤔 |
While Powershell doesn't create the prompt it seems
The difference would be the prompt, otherwise it shouldn't be noticable 🤔 |
82cb285
to
37be660
Compare
Related: microsoft/terminal#217 |
82eb8ea
to
cccad39
Compare
107f807
to
d54dab6
Compare
724845b
to
ef76fa2
Compare
ef76fa2
to
b6300bc
Compare
Can we backport this to 1.x? I'd be happy to give it a shot. |
@cowboyd 1.x is in feature freeze, only security issues will be addressed. I suggest you take a look at the migration guide if you need features introduced in the 2.x. |
What's the problem this PR addresses?
Due to the use of cmd jumper-files to spawn binaries, terminating scripts on Windows is horrendously annoying since CMD provides no way to disable the
Terminate batch job (Y/N)
promptFixes #1592
How did you fix it?
Create the jumper files using https://github.com/merceyz/binjumper to avoid the prompts
Checklist