[Bug?]: package.json that gets packed doesn't contain changes from after prepack

[wojtekmaj]

Self-service

• I'd be willing to implement a fix

Describe the bug

package.json that gets packed is a version from before prepack or from after postpack. I think this is confusing - I was under impression that after prepack and before postpack is a window of time when all files are collected and packaged.

To reproduce

• In prepack script, add a script that modifies package.json
• in postpack script, add a script that restores package.json
• Call yarn pack
• Explore package.tgz

Environment

System:
    OS: macOS 12.0
    CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
  Binaries:
    Node: 16.5.0 - /private/var/folders/h7/yd7dwy6x5fqgw_gkv2gb_vw80000gp/T/xfs-23c51887/node
    Yarn: 3.0.0 - /private/var/folders/h7/yd7dwy6x5fqgw_gkv2gb_vw80000gp/T/xfs-23c51887/yarn
    npm: 7.19.1 - /usr/local/bin/npm

Additional context

Reproducible at https://github.com/wojtekmaj/enzyme-adapter-react-17/tree/502e1346f871418919275955b9ca267be0c3d6bd

[merceyz]

Duplicate of #3145

[merceyz]

This was fixed in #3146 which is currently in a canary release

yarn set version canary

---

I see that you made a script in wojtekmaj/enzyme-adapter-react-17@e3cadb1 to remove and restore the workspaces key but you can use a plugin for this which doesn't mutate the file on disk.

module.exports = {
	name: `plugin-remove-workspaces-field`,
	factory: () => ({
		hooks: {
			beforeWorkspacePacking(workspace, rawManifest) {
				delete rawManifest.workspaces;
			},
		},
	}),
};