Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: remove unused --save option for set resolution command
Browse files Browse the repository at this point in the history
The option was never implemented in berry, but it's mentioned in the docs as well
as in the CLI output.

See #2202

I don't have the expertise to actually implement the flag, so the second best thing to do here
is to remove it, so that people are no longer mislead.
akwodkiewicz authored Oct 25, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 1a57559 commit aa5a616
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ export default class SetResolutionCommand extends BaseCommand {
details: `
This command updates the resolution table so that \`descriptor\` is resolved by \`resolution\`.
Note that by default this command only affect the current resolution table - meaning that this "manual override" will disappear if you remove the lockfile, or if the package disappear from the table. If you wish to make the enforced resolution persist whatever happens, add the \`-s,--save\` flag which will also edit the \`resolutions\` field from your top-level manifest.
Note that by default this command only affect the current resolution table - meaning that this "manual override" will disappear if you remove the lockfile, or if the package disappear from the table. If you wish to make the enforced resolution persist whatever happens, edit the \`resolutions\` field in your top-level manifest.
Note that no attempt is made at validating that \`resolution\` is a valid resolution entry for \`descriptor\`.
`,
@@ -24,10 +24,6 @@ export default class SetResolutionCommand extends BaseCommand {
]],
});

save = Option.Boolean(`-s,--save`, false, {
description: `Persist the resolution inside the top-level manifest`,
});

descriptor = Option.String();
resolution = Option.String();

0 comments on commit aa5a616

Please sign in to comment.