Replace odd characters in parameter names #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xR thanks, could you please check tests, |
|
You might need to run npm install again. After that the tests ran
succesfully on my machine.
We could also set up a CI to run tests automatically.
Op wo 13 jun. 2018 09:33 schreef Roman Krivtsov <[email protected]>:
… @0xR <https://github.com/0xR> thanks, could you please check tests, should
convert to special-parameters.graphql is failed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGH2MPO_8e9N3u2XJzwAvdGN0m2OnTfqks5t8LJUgaJpZM4UGDMM>
.
|
|
@0xR fixed it, the error was in fixture, parameter |
|
Added Travis as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure dashes in parameter names are handled gracefully.
With proper tests!
Depends on yarax/node-request-by-swagger#8