Allow 2.0.0-beta's to use current templates. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a few reasons the `semver.satisfies` function does not match prelease versions in the same way as we want (it does make sense though). See https://github.com/npm/node-semver#prerelease-tags. This PR switches over to use the simpler `gt`/`lt` methods which behaves much more like what we need with prerelease versions. A few examples using `semver.lt`: ``` > semver.lt('1.12.0-beta.1', '1.13.0') true > semver.lt('1.13.0-beta.1', '1.13.0') true > semver.lt('1.12.0', '1.13.0-beta.1') true > semver.lt('2.0.0', '1.13.0-beta.1') false > semver.lt('1.13.0', '1.13.0-beta.1') false > semver.lt('1.13.0-beta.1', '1.13.0-beta.1') false ```
rwjblue
force-pushed
the
use-lt-instead-of-satisfieds
branch
from
9f7d326 to
5dc0a65
Compare
|
Fixed issue with failing test (it was silly bower doing silly things). |
lukemelia
added a commit
that referenced
this pull request
Jun 19, 2015
Allow 2.0.0-beta's to use current templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a few reasons the
semver.satisfiesfunction does not matchprelease versions in the same way as we want (it does make sense
though).
See https://github.com/npm/node-semver#prerelease-tags.
This PR switches over to use the simpler
gt/ltmethods which behavesmuch more like what we need with prerelease versions.
A few examples using
semver.lt:Thanks to @ef4 for pointing this out!