Removed {{action}} helper from docs-app #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Dec 5, 2024
Comment on lines
-31
to
-33
| assert.hasDataTest( | ||
| dialogSelector, | ||
| 'my-data-test', |
There was a problem hiding this comment.
I removed the assertions with my-data-test, because they, in essence, test if Ember's splattributes work.
lukemelia
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Ember
5.xdeprecated the{{action}}helper. By removing the uses fromdocs-app/dummy(before removing those inaddon), we can separate whyember-release,ember-beta, andember-canary(all now point to6.x) currently fail.To remove the
{{action}}helper and simplify the controllers, I created a reusable component called<DemoModal>. After refactoring the route templates to consume this component, I updated the sample code to not show the{{action}}helper anymore.