Start on embroider support #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukemelia @pzuraq it looks like we need to update liquid-wormhole to fix embroider |
Closed
2 tasks
RobbieTheWagner
force-pushed
the
add-embroider-support
branch
from
987af0d to
b2a4f38
Compare
|
Per @rwwagner90: "From what I can tell, I think the PR fixes embroider for consuming apps, so it might be worth merging. I'm guessing if you use the liquid stuff it would break again" Based on this, I will merge this PR as a step in the right direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.