Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dummy: Remove obsolete register-subclassed-modals initializer #330

Merged
merged 1 commit into from
May 21, 2021

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented May 21, 2021

All of the subclasses already read the destinationElementId from the service in the constructor, so this should not be necessary anymore.

All of the subclasses already read the `destinationElementId` from the service in the constructor, so this should not be necessary anymore.
@lukemelia lukemelia merged commit 2eda605 into yapplabs:master May 21, 2021
@Turbo87 Turbo87 deleted the dummy branch May 21, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants