Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing jQuery #234

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Removing jQuery #234

merged 2 commits into from
Feb 22, 2018

Conversation

gmurphey
Copy link
Contributor

@gmurphey gmurphey commented Dec 8, 2017

Closes #227.

@BryanCrotaz
Copy link

This has been ready for 2 months - can we get it merged? Completely broken in Ember 2.18 and this should fix it

@BryanCrotaz
Copy link

@lukemelia nudge

@lukemelia
Copy link
Contributor

Thanks for this PR @gmurphey and for the nudge @BryanCrotaz. There are a lot of changes here. I would feel more comfortable merging if a few people could try out this PR in their app and give it a thumbs up.

@BryanCrotaz
Copy link

How do you reference a PR in npm?

@gmurphey
Copy link
Contributor Author

gmurphey commented Feb 6, 2018

@BryanCrotaz should be able to use gmurphey/ember-modal-dialog#no-jquery in place of the version.

@BryanCrotaz
Copy link

I started by searching for it to fork it, but github sayeth We couldn’t find any repositories matching 'gmurphey/ember-modal-dialog'

@gmurphey
Copy link
Contributor Author

gmurphey commented Feb 6, 2018

@BryanCrotaz
Copy link

Thanks. That's really odd - you're not listed when you search github for ember-modal-dialog, but that link works!

@BryanCrotaz
Copy link

BryanCrotaz commented Feb 6, 2018

Tested and worked first time. Without this fix you get an error that document is undefined when closing the dialog.

@lukemelia lukemelia merged commit d6f204f into yapplabs:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants