Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced overlay-class and container-class attributes. #18

Merged
merged 1 commit into from
Apr 13, 2015

Conversation

lukemelia
Copy link
Contributor

This commit reworks how css classes are provided to the modal-dialog component
and then handed down to the overlay div and the position-container component.
Previously, we attempted to use one property for both template-provided css
classes as well as subclass-provided css classes. That is problematic for the
same reason that Ember separates classNames and classNameBindings. After this
commit, if you want to specify additional class name(s) when you are using
modal-dialog in a hbs template, use overlay-class and/or
container-class, and if you want to specify additional class names(s) when
you are subclasses the modal-dialog component, use overlayClassNames
and/or containerClassNames. The dummy app has been updated with examples.

This commit reworks how css classes are provided to the modal-dialog component and then handed down to the overlay div and the position-container component. Previously, we attempted to use one property for both template-provided css classes as well as subclass-provided css classes. That is problematic for the same reason that Ember separates classNames and classNameBindings. After this commit, if you want to specify additional class name(s) when you are using `modal-dialog` in a hbs template, use `overlay-class` and/or `container-class`, and if you want to specify additional class names(s) when you are subclasses the `modal-dialog` component, use `overlayClassNames` and/or `containerClassNames`. The dummy app has been updated with examples.
lukemelia added a commit that referenced this pull request Apr 13, 2015
Introduced overlay-class and container-class attributes.
@lukemelia lukemelia merged commit 9440bde into master Apr 13, 2015
@lukemelia lukemelia deleted the rework-css-classes branch April 13, 2015 22:34
@sandstrom
Copy link
Contributor

Out of curiosity, is there a reason these were named container-class instead of containerClass?
(the format I've mostly seen used for component properties)

@lukemelia
Copy link
Contributor Author

@sandstrom I suspect we are going to move toward html naming style for component attributes as we start using angle bracket components. I was experimenting around that idea.

@sandstrom
Copy link
Contributor

Ah, okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants