Introduced overlay-class and container-class attributes. #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks how css classes are provided to the modal-dialog component
and then handed down to the overlay div and the position-container component.
Previously, we attempted to use one property for both template-provided css
classes as well as subclass-provided css classes. That is problematic for the
same reason that Ember separates classNames and classNameBindings. After this
commit, if you want to specify additional class name(s) when you are using
modal-dialog
in a hbs template, useoverlay-class
and/orcontainer-class
, and if you want to specify additional class names(s) whenyou are subclasses the
modal-dialog
component, useoverlayClassNames
and/or
containerClassNames
. The dummy app has been updated with examples.