-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks within an engine #233
Labels
Comments
is this solved @denzo @samselikoff |
@swarnavallis don't believe so, and looks like nobody else is really on it. If you're in a spot where you need it I'd encourage you to try to fix it! |
👋 Any workaround about this issue ? I tried to find one on my side but I'm stuck... |
buschtoens
added a commit
to buschtoens/ember-modal-dialog
that referenced
this issue
Dec 26, 2020
Submitted a fix: #315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When this addon is a dependency of the engine the initializer throws an error as
App.rootElement
isundefined
. This is becauseApp
in the initializer of the engine isEngine
.https://github.com/yapplabs/ember-modal-dialog/blob/master/addon/initializers/add-modals-container.js#L31
The text was updated successfully, but these errors were encountered: