Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks within an engine #233

Closed
denzo opened this issue Dec 5, 2017 · 4 comments · Fixed by #315
Closed

Breaks within an engine #233

denzo opened this issue Dec 5, 2017 · 4 comments · Fixed by #315
Labels

Comments

@denzo
Copy link

denzo commented Dec 5, 2017

When this addon is a dependency of the engine the initializer throws an error as App.rootElement is undefined. This is because App in the initializer of the engine is Engine.

https://github.com/yapplabs/ember-modal-dialog/blob/master/addon/initializers/add-modals-container.js#L31

@swarnavallis
Copy link

swarnavallis commented Aug 6, 2019

is this solved @denzo @samselikoff

@samselikoff
Copy link
Collaborator

@swarnavallis don't believe so, and looks like nobody else is really on it. If you're in a spot where you need it I'd encourage you to try to fix it!

@romgere
Copy link

romgere commented Jan 14, 2020

👋 Any workaround about this issue ? I tried to find one on my side but I'm stuck...
I tried to find a way to access to the application instance inside the engine initializer, but I failed 😞

buschtoens added a commit to buschtoens/ember-modal-dialog that referenced this issue Dec 26, 2020
@buschtoens
Copy link
Contributor

Submitted a fix: #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants