Entering a valid hex code sets the color #14
Conversation
lorcan
force-pushed
the
lorcan/entering-a-valid-hex-sets-the-color
branch
from
d52f03a to
cf0e690
Compare
|
Hi there, anything I can do to progress this PR? (I'm working on an app that has users that encounters this issue fairly regularly.) |
|
Hi @lorcan. Sorry for the silence on this. This looks like a good improvement to me. Can you add test coverage? |
|
Great, will do @lukemelia, thanks :-) |
lorcan
force-pushed
the
lorcan/entering-a-valid-hex-sets-the-color
branch
from
cf0e690 to
20264fe
Compare
Either pasting a hex value or typing a hex-like value into the hex input sets the preview value and the value.
lorcan
force-pushed
the
lorcan/entering-a-valid-hex-sets-the-color
branch
from
20264fe to
73b99f1
Compare
| Ember.run(function() { | ||
| component.$('.colpick_hex_field input').val('ff0000').keyup(); | ||
| }); | ||
| assert.equal(component.get('value'), 'ff0000', 'After receiving six hex characters the color is set'); |
There was a problem hiding this comment.
This last assertion fails on master.
Avoids ember-cli/ember-cli#5316 which was causing CI to time out.
lorcan
force-pushed
the
lorcan/entering-a-valid-hex-sets-the-color
branch
from
6fbb957 to
5d4ab03
Compare
|
Hey @lukemelia, sorry about the delay on this. I've added the tests plus a commit to get CI working again. We should be ready to go now :-) Any thoughts on upgrading the ember version of this plugin? I'd be more than happy to put some time into it :-) |
| @@ -9,7 +9,7 @@ | |||
| "ember-qunit": "0.3.1", | |||
| "ember-qunit-notifications": "0.0.7", | |||
| "ember-resolver": "~0.1.15", | |||
| "jquery": "^1.11.1", | |||
| "jquery": "1.11.1", | |||
There was a problem hiding this comment.
|
Hi there, any chance we could get this one merged and get a bump on the version? I've added a test to cover the functionality and fixed CI. |
|
@lorcan I'm happy to do that. What's the issue with the jQuery version? Is there a version dependency we need to document? |
|
It's an issue with the version of ember being used - there's more details here and a good description here:
It was fixed in ember by emberjs/ember.js#12793. |
|
I'd be happy to produce PRs to update both ember-cli and ember for this project in a bit (though probably not this week). |
|
Sounds good @lorcan. I'll go ahead and cut a release in the meantime. |
|
Awesome!!! Thanks a mil @lukemelia :-D |
|
Hi @lukemelia, any chance you could cut a release to get this out? |
|
@lorcan published at 0.6.1. Thanks! |
|
Super, thanks @lukemelia! |
Either pasting a hex value or typing a hex-like value into the hex
input sets the preview value and the value.
Looks like this (first I type in two valid hex strings, then I paste in a valid hex string):