Fix: Remove UNSET
objects from lists
#26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example repro:
Running with githubkit version 0.9.8:
I figured out that the
exclude_unset()
function doesn't traverse lists, soUNSET
objects inside dicts are not excluded if they are inside a list.There might be other data types we might want to add to this list (
set
,tuple
, etc), though I didn't check to see how often these where used in the models (if at all).