Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make query, header, cookie params keyword only #167

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

yanyongyu
Copy link
Owner

@yanyongyu yanyongyu commented Nov 22, 2024

some optional query params may come before required params. this will cause syntax error.

such as:

    def get_time_stats(
        self,
        org: str,
        min_timestamp: str,
        max_timestamp: Missing[str] = UNSET,
        timestamp_increment: str,
        *,
        headers: Optional[dict[str, str]] = None,
    ) -> Response[list[ApiInsightsTimeStatsItems], list[ApiInsightsTimeStatsItemsType]]:
        """See also: https://docs.github.com/rest/orgs/api-insights#get-time-stats"""

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@yanyongyu yanyongyu added the bug Something isn't working label Nov 22, 2024
@yanyongyu yanyongyu merged commit 470e370 into master Nov 22, 2024
33 of 34 checks passed
@yanyongyu yanyongyu deleted the fix/optional-query branch November 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant