Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: improve request error structure #145

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Conversation

yanyongyu
Copy link
Owner

RequestTimeout and RequestFailed are subclass of RequestError now.

@yanyongyu yanyongyu added the enhancement New feature or request label Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 17.82%. Comparing base (3865ae3) to head (d7ca09e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
githubkit/core.py 0.00% 4 Missing ⚠️
githubkit/exception.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   17.82%   17.82%           
=======================================
  Files        4842     4842           
  Lines      223455   223460    +5     
=======================================
+ Hits        39835    39838    +3     
- Misses     183620   183622    +2     
Flag Coverage Δ
unittests 17.82% <53.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanyongyu yanyongyu merged commit 270b57c into master Oct 5, 2024
36 checks passed
@yanyongyu yanyongyu deleted the feat/request-excs branch October 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant