Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable timeout for zk_lock retry #73
Add configurable timeout for zk_lock retry #73
Changes from 4 commits
6009c65
ef0322b
9cc5e94
5395999
72b3c82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantics of using
exitcode
config field was changed by this. Originally it was exit code in case of failed zk lock acquisition. But now only0
will be actual exit code.As for exception, it can be catched and swallowed (maybe unintentionally).
Is it intended ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are using
blocking=True
,acquire()
raises an exception if the lock wasn't acquired withintimeout
secondshttps://github.com/python-zk/kazoo/blob/92bd0c2a8540697633564deed683f87d1f611bf5/kazoo/recipe/lock.py#L155
We shouldn't check the return value in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it handled somewhere ? How about
sys.exit(self._exitcode)
here orlock_config.exitcode
where we catch and handle this exception to respectlock_conf.exitcode
in all cases