Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if backup name exists and add retry on ClickhouseError for queries #173

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

kirillgarbar
Copy link
Contributor

Retries are added in case of OOM on SELECT and something similar, but we decided that retry can be set for every type of exception.

@@ -37,7 +37,7 @@ def settings(self):
"""
return self._session.params

@retry(requests.exceptions.ConnectionError)
@retry((requests.exceptions.ConnectionError, ClickhouseError))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry of a failed non-SELECT queries will cause unnecessary logs and longer fail time, in that case a check if query is a SELECT query can be added with retries on ClickhouseSelectError or something similar

@aalexfvk aalexfvk merged commit 44b84c2 into yandex:main Jul 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants