Encrypt backup metadata #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexfvk
reviewed
Jul 16, 2024
| raise StorageError("Failed to download backup metadata") from e | ||
| return self._load_metadata(path, not use_light_meta) | ||
| except CryptoError: | ||
| return self._load_metadata(path, False) |
There was a problem hiding this comment.
Now it seems it is better to do it with a flag for consistency with data encryption
There was a problem hiding this comment.
It is decided to keep the current approach, to avoid downloading light metadata every time, especially when all backups will be encrypted.
But let's add log message here to discover cases when file is actually corrupted.
aalexfvk
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.