Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Cluster #10

Closed
ghost opened this issue Feb 26, 2016 · 3 comments
Closed

Meta Cluster #10

ghost opened this issue Feb 26, 2016 · 3 comments
Milestone

Comments

@ghost
Copy link

ghost commented Feb 26, 2016

Hi

Could you please explain the concept of meta clusters? I am interested in the reason why these aren't configurable? Is this to prevent changes in prod?

Kind Regards
Brian

@chrisgray
Copy link
Contributor

Are you referring to this block of code? https://github.com/yammer/breakerbox/blob/master/breakerbox-service/src/main/java/com/yammer/breakerbox/service/core/Instances.java#L33-L50

If so, the idea of MetaClusters was something that actually didn't have specific instances but was made up of multiple difference clusters. Here we often create dashboards that are made up of multiple clusters of instances that represent our deployment environments. You can also imagine dashboards that are feature-focused that are representative of the backing instances.

You raise a good point in that they should be configurable. They absolutely should be configurable. I'll make a point to get that in.

@chrisgray chrisgray modified the milestone: 0.3.4 Mar 2, 2016
@chrisgray
Copy link
Contributor

This is fixed by PR #14 which will be available in the next release

@ghost
Copy link
Author

ghost commented Mar 18, 2016

Many thanks for the fix. Apologies for not responding earlier.

chrisgray pushed a commit that referenced this issue Jun 24, 2016
too many headaches with = in an environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant