Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyyaml should detect duplicate keys and report an error. #41

Open
partofthething opened this issue Nov 22, 2016 · 2 comments
Open

pyyaml should detect duplicate keys and report an error. #41

partofthething opened this issue Nov 22, 2016 · 2 comments
Labels
task:bug

Comments

@partofthething
Copy link

(NOTE: This is a migration of pyyaml.org's ticket #128, see potential solutions there)

In the 1.1 spec I believe this is considered an error; currently libyaml silently accepts duplicate keys.
@partofthething partofthething changed the title libyaml should detect duplicate keys and report an error. pyyaml should detect duplicate keys and report an error. Nov 22, 2016
smetj pushed a commit to smetj/wishbone that referenced this issue Jun 12, 2017
Makes no sense to validate here because it's too late already, pyyaml…
be21f84 
… should catch this but doesn't yaml/pyyaml#41
smetj pushed a commit to smetj/wishbone that referenced this issue Jun 12, 2017
Makes no sense to validate here because it's too late already, pyyaml…
36e7091 
… should catch this but doesn't yaml/pyyaml#41
@lakshmi-kannan lakshmi-kannan mentioned this issue Jul 6, 2017
Open
smetj pushed a commit to smetj/wishbone that referenced this issue Sep 16, 2017
Makes no sense to validate here because it's too late already, pyyaml…
1963a6a 
… should catch this but doesn't yaml/pyyaml#41
smetj pushed a commit to smetj/wishbone that referenced this issue Sep 16, 2017
Makes no sense to validate here because it's too late already, pyyaml…
e68e4ca 
… should catch this but doesn't yaml/pyyaml#41
@albrow albrow mentioned this issue Oct 14, 2017
Closed
@collin5 collin5 mentioned this issue Jan 4, 2019
Closed
@blimpage blimpage mentioned this issue Jul 18, 2019
Merged
@marvingreenberg marvingreenberg mentioned this issue Aug 26, 2019
Open
@bob1de
Copy link

bob1de commented Oct 22, 2019

Hi,

Is there any progress on this? PyYAML silently accepting duplicate mapping keys lets people file issues every now and then because they try new configs and forget commenting out old keys and then wonder why the software they configure doesn't behave as expected...

If it's really needed for some internal functions of PyYAML, maybe accepting duplicate keys could be made an opt-out feature?

Best regards
Robert

@perlpunk
Copy link
Member

See also #165, for some reason all the discussion happened there. The problem to solve currently is how to implement it while still supporting merge keys.

@adamgreig adamgreig mentioned this issue Jul 5, 2021
Closed
@youngmit youngmit mentioned this issue Oct 6, 2021
Closed
@gohierf gohierf mentioned this issue Mar 7, 2022
Open
@fruch fruch mentioned this issue Aug 24, 2022
Merged
17 tasks
@dbeatty10 dbeatty10 mentioned this issue Sep 9, 2022
Closed
3 tasks
@scott-taubman scott-taubman mentioned this issue Feb 8, 2023
Merged
@AndroxxTraxxon AndroxxTraxxon mentioned this issue Jan 25, 2024
Open
@jpsim jpsim mentioned this issue Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@perlpunk @partofthething @bob1de