Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved package.json's rnpm config to react-native.config.js #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Moved package.json's rnpm config to react-native.config.js #353

wants to merge 2 commits into from

Conversation

chrisspankroy
Copy link

This is going to be required in the release after RN 0.60. I think I did this the right way, although someone else should probably take a look. This closes #352

@chrisspankroy
Copy link
Author

One thing I'm not sure about is if it should be

module.exports = {
    project: {
        ios: {
	    project: 'iOS/RCTOrientation.xcodeproj',
	},
	android: {
	    "packageInstance": "new OrientationPackage()"
	}
    }
};

or

module.exports = {
    dependency: {
        platforms: {
            ios: {
	        project: 'iOS/RCTOrientation.xcodeproj',
	    },
	    android: {
	        "packageInstance": "new OrientationPackage()"
	    }
        }
    }
};

Is there a way to test which one works?

@mayconmesquita
Copy link

+1

mgz added a commit to mgz/react-native-orientation that referenced this pull request Aug 9, 2019
@dawidvdh
Copy link

Is this planned to be merged in at some point? Is this project still maintained?

@zbagley
Copy link

zbagley commented Aug 19, 2019

Last PR closed was November of last year. This project is not maintained.

@Fenopiu
Copy link

Fenopiu commented Sep 2, 2019

@yamill last activity on GitHub was on 17 September 2018 and his personal website is down... I don't think this wonderful package will be ever maintained again from him. :-(
This is a fork updated version: https://github.com/wonday/react-native-orientation-locker

@joaodematejr
Copy link

I'm using this one and it worked perfectly on version 0.60.5

https://github.com/react-native-hooks/device-orientation

@chrisparton1991
Copy link

@joaodematejr that hook only allows you to query the current orientation of the display.

This library allows you to lock down the orientation of the display, so the hook isn't a valid replacemet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with RN 0.60
7 participants