-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved package.json's rnpm config to react-native.config.js #353
base: master
Are you sure you want to change the base?
Conversation
One thing I'm not sure about is if it should be module.exports = {
project: {
ios: {
project: 'iOS/RCTOrientation.xcodeproj',
},
android: {
"packageInstance": "new OrientationPackage()"
}
}
}; or module.exports = {
dependency: {
platforms: {
ios: {
project: 'iOS/RCTOrientation.xcodeproj',
},
android: {
"packageInstance": "new OrientationPackage()"
}
}
}
}; Is there a way to test which one works? |
+1 |
Is this planned to be merged in at some point? Is this project still maintained? |
Last PR closed was November of last year. This project is not maintained. |
@yamill last activity on GitHub was on 17 September 2018 and his personal website is down... I don't think this wonderful package will be ever maintained again from him. :-( |
I'm using this one and it worked perfectly on version 0.60.5 https://github.com/react-native-hooks/device-orientation |
@joaodematejr that hook only allows you to query the current orientation of the display. This library allows you to lock down the orientation of the display, so the hook isn't a valid replacemet. |
This is going to be required in the release after RN 0.60. I think I did this the right way, although someone else should probably take a look. This closes #352