Remove compatibility with OCaml 4.02 (makes ctypes stubs compatible with ocaml-multicore for free) #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stubs generation part of ctypes doesn't seem to be compatible with ocaml-multicore at the moment. For instance, the following error message is raised when trying to compile
decompress
which uses ctypes' stubs generation:Looking into it, it seems the direct use of
caml_local_roots
stems from a care for backwards compatibility. Given it is relatively easy to simply bump the required version and use the "new"CAMLdrop()
macro I feel like it might be worth doing anyway.